[3.10] gh-89452: GHA: Set --with-dbmliborder to avoid issues with homebrew's gdbm 1.24 by encukou · Pull Request #125112 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation5 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

@encukou

@encukou encukou commented

Oct 8, 2024

edited by bedevere-appbot

Loading

@encukou

…th homebrew's gdbm 1.24

Per python#89452 (comment), the issue is fixed in configure for 3.11+, and

For older Python versions, the workaround is to build with:

./configure --with-dbmliborder=gdbm:ndbm

We need this workaround in GitHub Actions, otherwise the tests fail.

This was referenced

Oct 8, 2024

@encukou

@ambv

@miss-islington-app

Thanks @encukou for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@encukou encukou deleted the mac-dbmliborder-3.10 branch

October 8, 2024 14:46

@miss-islington-app

Sorry, @encukou and @ambv, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 850189a64e7f0b920fe48cb12a5da3e648435680 3.9

encukou added a commit to encukou/cpython that referenced this pull request

Oct 9, 2024

@encukou

@bedevere-app

ambv added a commit that referenced this pull request

Oct 9, 2024

@encukou @ambv

Labels

2 participants

@encukou @ambv