bpo-36465: Make release and debug ABI compatible by vstinner · Pull Request #12615 · python/cpython (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Release build and debug build are now ABI compatible: the Py_DEBUG
define no longer implies Py_TRACE_REFS define which introduces the
only ABI incompatibility.
A new "./configure --with-trace-refs" build option is now required to
get Py_TRACE_REFS define which adds sys.getobjects() function and
PYTHONDUMPREFS environment variable.
Changes:
- Add ./configure --with-trace-refs
- Py_DEBUG no longer implies Py_TRACE_REFS
https://bugs.python.org/issue36465
I rebased my PR and I added a NEWS entry.
[WIP] bpo-36465: Py_DEBUG no longer implies Py_TRACE_REFS bpo-36465: Make release and debug ABI compatible
I reverted the following change:
* The "d" flag of SOABI (sys.implementation.cache_tag) is now
only added by --with-trace-refs. It is no longer added by
--with-pydebug.
I found an issue between libpython and SOABI: https://mail.python.org/pipermail/python-dev/2019-April/157186.html
I will work on a separated PR to remove "d" from SOABI, to handle properly the libpython issue.
This PR is not restricted to "Py_DEBUG no longer implies Py_TRACE_REFS".
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry, I'm not the one who should review this. I have no relevant knowledge any more.
Release build and debug build are now ABI compatible: the Py_DEBUG define no longer implies Py_TRACE_REFS define which introduces the only ABI incompatibility.
A new "./configure --with-trace-refs" build option is now required to get Py_TRACE_REFS define which adds sys.getobjects() function and PYTHONDUMPREFS environment variable.
Changes:
- Add ./configure --with-trace-refs
- Py_DEBUG no longer implies Py_TRACE_REFS
This was referenced
Aug 4, 2022
Reviewers
