bpo-31904 : skip test_cmd_line case for VxWorks doesn't support preexec by LihuaZhao · Pull Request #12648 · python/cpython (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation11 Commits6 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
support preexec
subprocess.Popen doesn't support preexec, test_cmd_line need to skip the case which use preexec
| if sys.platform == "vxworks": |
|---|
| return False |
| else: |
| return True |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest:
SUBPROCESS_SUPPORTS_PREEXEC = (sys.platform != "vxworks")
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.
Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
I have made the requested changes; please review again.
Thanks for making the requested changes!
@vstinner: please review the changes made to this pull request.
| @@ -18,7 +18,6 @@ |
|---|
| # Debug build? |
| Py_DEBUG = hasattr(sys, "gettotalrefcount") |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hum, please revert this unrelated change.
| @@ -0,0 +1 @@ |
|---|
| Skip test case in test_cmd_line for VxWorks doesn't support preexec when do Popen |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly, I'm not sure that it's worth it to document invidivual tests changes. Can you please remove the NEWS entry? I will simply add the GitHub label "skip news".
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.
Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
And if you don't make the requested changes, you will be poked with soft cushions!
I have made the requested changes; please review again.
Thanks for making the requested changes!
@vstinner: please review the changes made to this pull request.
@vstinner: Please replace # with GH- in the commit message next time. Thanks!
bpo-31904: skip test_cmd_line case for VxWorks doesn't support preexec bpo-36648 : skip test_cmd_line case for VxWorks doesn't support preexec
bpo-36648 : skip test_cmd_line case for VxWorks doesn't support preexec bpo-31094 : skip test_cmd_line case for VxWorks doesn't support preexec
bpo-31094 : skip test_cmd_line case for VxWorks doesn't support preexec bpo-31904 : skip test_cmd_line case for VxWorks doesn't support preexec
