bpo-30840: Document relative imports by nanjekyejoannah · Pull Request #12831 · python/cpython (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation20 Commits13 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some editing notes. I have marked this review as "Comment" rather than "Request changes", because I did not see any problems with the grammar, and my notes are mainly stylistic.
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No more style and grammar issues from my end, though I'll defer to someone else about whether or not this solves the bpo issue (@ncoghlan maybe?)
Thanks!
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.
Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
I have made the requested changes; please review again .
@nanjekyejoannah Do note that you need to reply with I have made the requested changes; please review again to trigger our bot to recognize that you're ready for a new review.
@nanjekyejoannah just so you know for future PRs, the magic phrase needs to be in a new comment, otherwise the bot won't pick it up. But I have gone ahead and manually changed the label and requested @ncoghlan to do another review.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I was going to suggest adding a hyphen as part of the new cross-reference label, but we're currently missing one of those in the importsystem target as well, so leaving it out is consistent within this particular file.
@ncoghlan: Please replace # with GH- in the commit message next time. Thanks!
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request
document relative imports
📜🤖 Added by blurb_it.
fix indentation error
remove indentation
Document relative imports
Document relative imports
remove from ...package
Document relative imports
remove trailing space
Document relative imports
Document relative imports (cherry picked from commit 70bf713)
Co-authored-by: Joannah Nanjekye 33177550+nanjekyejoannah@users.noreply.github.com
Hmm, I just had the GitHub commit message editor break on me again:
- told me the squash & merge had failed
- actually went ahead and squashed and merged anyway, but didn't include my commit message changes
ncoghlan pushed a commit that referenced this pull request
- Document relative imports (cherry picked from commit 70bf713)
Co-authored-by: Joannah Nanjekye 33177550+nanjekyejoannah@users.noreply.github.com
Labels
Documentation in the Doc dir