gh-89745: Remove dead realpath branch in getpath.c by pelson · Pull Request #128861 · python/cpython (original) (raw)
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
The readlink code before is always taking precedence, and I don't know of a platform which has realpath but not readlink.
Note that this is a bit of a speculative change identified when tackling another getpath[.py] issue - I have no broad knowledge of platforms to be 100% certain that realpath without readlink isn't a thing.
@FFY00 and @zooba - is this a worthwhile change? If so, I'm happy to open up an issue, rebase, etc.
If not, I would also be happy to just close the PR.
gh-XXXXX: Remove dead realpath branch in getpath.c gh-89745: Remove dead realpath branch in getpath.c
This comment was marked as resolved.
I have no broad knowledge of platforms to be 100% certain that realpath without readlink isn't a thing.
Me neither. I'm not confident to remove code that I copy-pasted (I assume from posixmodule.c, possibly from fileutils.c, but I expect if it were there then I could've just called it).