bpo-32424: Improve test coverage for xml.etree.ElementTree by GPHemsley · Pull Request #12891 · python/cpython (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation32 Commits2 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
(Spun off from #5046.)
Add unit tests to improve coverage for xml.etree.ElementTree.
According to my testing, these should all pass in both the C and Python implementations of ElementTree.
https://bugs.python.org/issue32424
@serhiy-storchaka @scoder Can you review these with fresh eyes? I haven't necessarily attempted to address comments from the previous PR, but I want to make sure we at least have a separation of concerns.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comments from GH-5046 still apply.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.
Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
The comments from GH-5046 still apply.
I was hoping to get them fresh here to ensure that discussions didn't get conflated. (Note that I removed tests that would fail due to the other issues discussed in #5046 and elsewhere.)
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the comments that I think still apply.
Improve test coverage for xml.etree.ElementTree bpo-32424: Improve test coverage for xml.etree.ElementTree
@scoder Note that I explicitly did not include an issue number on this PR because it is not directly tied to any issue and does not resolve any open tickets. Rather, it is a prerequisite to my changes for both bpo-32424 and bpo-36685.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed comments.
I have made the requested changes; please review again.
Thanks for making the requested changes!
@scoder: please review the changes made to this pull request.
Thanks for sticking with this!
Labels
Tests in the Lib/test dir