bpo-36260: Add pitfalls to zipfile module documentation by krnick · Pull Request #13378 · python/cpython (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation7 Commits4 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
We saw vulnerability warning description (including zip bomb) in Doc/library/xml.rst file.
This gave us the idea of documentation improvement.
So, we moved a little bit forward :D
https://bugs.python.org/issue36260
We saw vulnerability warning description (including zip bomb) in Doc/library/xml.rst file. This gave us the idea of documentation improvement.
So, we moved a little bit forward :P And the doc patch can be found (pr).
@krnick, your pull request is failing the CI builds because of trailing whitespace. Please correct that. Thank you!
@csabella Sorry for the mistake, I have fixed it.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After discussing with @tiran, we're happy to include this section. I've done some minor reformatting for consistency.
@jaraco: Please replace #
with GH-
in the commit message next time. Thanks!
Thanks @krnick for the PR, and @jaraco for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request
- bpo-36260: Add pitfalls to zipfile module documentation
We saw vulnerability warning description (including zip bomb) in Doc/library/xml.rst file. This gave us the idea of documentation improvement.
So, we moved a little bit forward :P And the doc patch can be found (pr).
fix trailing whitespace
📜🤖 Added by blurb_it.
Reformat text for consistency. (cherry picked from commit 3ba51d5)
Co-authored-by: JunWei Song sungboss2004@gmail.com
jaraco pushed a commit that referenced this pull request
- bpo-36260: Add pitfalls to zipfile module documentation
We saw vulnerability warning description (including zip bomb) in Doc/library/xml.rst file. This gave us the idea of documentation improvement.
So, we moved a little bit forward :P And the doc patch can be found (pr).
fix trailing whitespace
📜🤖 Added by blurb_it.
Reformat text for consistency. (cherry picked from commit 3ba51d5)
Co-authored-by: JunWei Song sungboss2004@gmail.com
DinoV pushed a commit to DinoV/cpython that referenced this pull request
- bpo-36260: Add pitfalls to zipfile module documentation
We saw vulnerability warning description (including zip bomb) in Doc/library/xml.rst file. This gave us the idea of documentation improvement.
So, we moved a little bit forward :P And the doc patch can be found (pr).
fix trailing whitespace
📜🤖 Added by blurb_it.
Reformat text for consistency.
tkarabela added a commit to tkarabela/cpython that referenced this pull request
Co-authored-by: Florent Xicluna florent.xicluna@gmail.com
Labels
Documentation in the Doc dir