bpo-36260: Add pitfalls to zipfile module documentation by krnick · Pull Request #13378 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation7 Commits4 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

krnick

We saw vulnerability warning description (including zip bomb) in Doc/library/xml.rst file.
This gave us the idea of documentation improvement.

So, we moved a little bit forward :D

https://bugs.python.org/issue36260

@krnick

We saw vulnerability warning description (including zip bomb) in Doc/library/xml.rst file. This gave us the idea of documentation improvement.

So, we moved a little bit forward :P And the doc patch can be found (pr).

auvipy

@csabella

@krnick, your pull request is failing the CI builds because of trailing whitespace. Please correct that. Thank you!

@krnick

@krnick

@csabella Sorry for the mistake, I have fixed it.

@csabella

@blurb-it

@jaraco

jaraco

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After discussing with @tiran, we're happy to include this section. I've done some minor reformatting for consistency.

@bedevere-bot

@jaraco: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington

Thanks @krnick for the PR, and @jaraco for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Sep 11, 2019

@krnick @miss-islington

We saw vulnerability warning description (including zip bomb) in Doc/library/xml.rst file. This gave us the idea of documentation improvement.

So, we moved a little bit forward :P And the doc patch can be found (pr).

Co-authored-by: JunWei Song sungboss2004@gmail.com

@bedevere-bot

jaraco pushed a commit that referenced this pull request

Sep 11, 2019

…H-15976)

We saw vulnerability warning description (including zip bomb) in Doc/library/xml.rst file. This gave us the idea of documentation improvement.

So, we moved a little bit forward :P And the doc patch can be found (pr).

Co-authored-by: JunWei Song sungboss2004@gmail.com

DinoV pushed a commit to DinoV/cpython that referenced this pull request

Sep 12, 2019

@krnick @DinoV

We saw vulnerability warning description (including zip bomb) in Doc/library/xml.rst file. This gave us the idea of documentation improvement.

So, we moved a little bit forward :P And the doc patch can be found (pr).

tkarabela added a commit to tkarabela/cpython that referenced this pull request

Nov 30, 2022

@tkarabela @florentx

Co-authored-by: Florent Xicluna florent.xicluna@gmail.com

Labels

docs

Documentation in the Doc dir