bpo-36763: Remove _PyCoreConfig.dll_path by vstinner · Pull Request #13402 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation1 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

According to @zooba, there is no benefit to configure dll_path:

The dll_path field of PyConfig says "Windows only". Does that meant the
struct doesn't have that field except in a Windows build? Or is it
ignored, instead? If it doesn't have that field at all, what #define can
be used to determine if the PyConfig struct will have it or not?

This field doesn't need to be here. It exists because it was used in
getpathp.c, and Victor's internal refactoring has kept it around through
all the field movement.

https://mail.python.org/pipermail/python-dev/2019-May/157451.html

I understood that it would allow to decide where Python looks for DLL. It seems like I misunderstood the purpose of this field. So let's remove it :-)