bpo-36974: tp_print -> tp_vectorcall_offset and tp_reserved -> tp_as_async by jdemeyer · Pull Request #13464 · python/cpython (original) (raw)
@jdemeyer please keep calm.
Relax, breath in and out.
I understand and share @encukou and @markshannon objections.
109 changed files are too much, even if the change is about comments only.
Please split the PR into 109 ones for one module at once.
Even better, let's change PyTypeObject
definitions to use a new syntax like
static PyTypeObject FutureType = {
PyVarObject_HEAD_INIT(NULL, 0)
"_asyncio.Future",
sizeof(FutureObj), /* tp_basicsize */
.tp_dealloc = FutureObj_dealloc,
.tp_as_async = &FutureType_as_async,
...
Sorry, it takes much more work. Maybe some related modules can be addressed by single PR.
As a reviewer, I can overview the module change and approve it instantly if the scope of changes is narrow.
We can open "easy issue" on https://bugs.python.org to track the change. People will help, sure.