bpo-36624: Add platform constants in test.support by taleinat · Pull Request #13648 · python/cpython (original) (raw)

On Wed, May 29, 2019 at 02:43:16AM -0700, Michael Felt wrote: imho - this adds clarity to the whole.
I don't think so: Now I have to wonder which of the different idioms hides behind MS_WINDOWS. And in other project's setup.py files I still need sys.platform, so now there's even one additional way to accomplish the same thing.

So, Python does nothing?

Doing this in "test" gives "the example" on how it should be done.

As to the areas outside of test, and even within test (e.g., for bsd*) I am willing to make this "my mission" to bring uniformity wherever possible. This was not even my idea :) - this was a suggestion on how I could contribute something to the whole.

Again, if not clear before - I do not see it stopping here - but would clearly welcome direction on where to set priorities.

It is not my call - I am not in python-dev mailing list - so I will not see a discussion there. If the group feels this is wrong - I have no direct interest in any decision made - other than my attempt - read desire - to contribute to Python.

Regards,
Michael