bpo-36974: Fix GDB integration by encukou · Pull Request #13665 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation4 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

buildbot fix for #13185

As it changes the way functions are called, the PEP 590 implementation
skipped the functions that the GDB integration is looking for
(by name) to find function calls.

Looking for the new helper cfunction_call_varargs should fix buildbots.

The changed frame nuber in test_gdb is due to there being fewer
C calls when calling a built-in funciton/method.

https://bugs.python.org/issue36974

As it changes the way functions are called, the PEP 590 implementation skipped the functions that the GDB integration is looking for (by name) to find function calls.

Looking for the new helper cfunction_call_varargs hopefully fixes the tests, and thus buildbots.

The changed frame nuber in test_gdb is due to there being fewer C calls when calling a built-in method.

Could you change this comment:

        # Tested function must not be defined with METH_NOARGS or METH_O,
        # otherwise call_function() doesn't call PyCFunction_Call()

I'm planning a follow-up with a better fix; I'll change the comment there. This is a quick patch to fix the buildbots.

Thanks a lot (assuming that this actually fixes the buildbots)!

It dit! 🎉

And #13668 is that follow-up.

DinoV pushed a commit to DinoV/cpython that referenced this pull request

Jan 14, 2020

As it changes the way functions are called, the PEP 590 implementation skipped the functions that the GDB integration is looking for (by name) to find function calls.

Looking for the new helper cfunction_call_varargs hopefully fixes the tests, and thus buildbots.

The changed frame nuber in test_gdb is due to there being fewer C calls when calling a built-in method.