bpo-37351: Removes libpython38.a from standard Windows distribution by zooba · Pull Request #14276 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation5 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

zooba

@zooba

@bedevere-bot

@zooba: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington

Sorry @zooba, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker f5690925df897cf45818bf944b28d13f37b9f8ca 3.8

@zooba zooba deleted the bpo-37351 branch

June 21, 2019 21:28

zooba added a commit to zooba/cpython that referenced this pull request

Jun 21, 2019

@zooba

@bedevere-bot

@bedevere-bot

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot x86 Gentoo Installed with X 3.x has failed when building commit f569092.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/103/builds/2686) and take a look at the build logs.
  4. Check if the failure is related to this commit (f569092) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/103/builds/2686

Click to see traceback logs

From https://github.com/python/cpython

Objects/unicodeobject.c: In function ‘_PyUnicode_CheckConsistency’: Objects/unicodeobject.c:459:15: warning: variable ‘data’ set but not used [-Wunused-but-set-variable] void *data; ^~~~ Python/peephole.c: In function ‘PyCode_Optimize’: Python/peephole.c:258:19: warning: comparison of integer expressions of different signedness: ‘unsigned int’ and ‘Py_ssize_t’ {aka ‘int’} [-Wsign-compare] for (j = 0; j < tabsiz; j += 2) { ^ Python/pystrhex.c: In function ‘_Py_strhex_impl’: Python/pystrhex.c:60:27: warning: comparison of integer expressions of different signedness: ‘unsigned int’ and ‘Py_ssize_t’ {aka ‘const int’} [-Wsign-compare] if (abs_bytes_per_sep >= arglen) { ^~

/buildbot/tmp/tmpdir/tmpggoihase/pip-19.0.3-py2.py3-none-any.whl/pip/_vendor/pyparsing.py:3068: SyntaxWarning: invalid escape sequence \w /buildbot/tmp/tmpdir/tmpggoihase/pip-19.0.3-py2.py3-none-any.whl/pip/_vendor/pyparsing.py:3068: SyntaxWarning: invalid escape sequence \w

zooba added a commit that referenced this pull request

Jun 22, 2019

@zooba

lisroach pushed a commit to lisroach/cpython that referenced this pull request

Sep 10, 2019

@zooba @lisroach

DinoV pushed a commit to DinoV/cpython that referenced this pull request

Jan 14, 2020

@zooba @DinoV