bpo-20177: use builtin_dir to test METH_VARARGS by jdemeyer · Pull Request #14330 · python/cpython (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation3 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Maybe add a function to testcapi to not have to update tests each time the tested function uses a different calling convention.
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @vstinner, these tests are fragile because it seems they're testing incidental implementation details of these builtins that are not guaranteed.
Unless these properties are guaranteed for backwards-compatibility, I think replacing these with dedicated test functions with a guaranteed calling method is the right way to test it.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.
Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.