bpo-10945: Drop support for bdist_wininst on non-Windows systems by hroncok · Pull Request #14506 · python/cpython (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation19 Commits4 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
bdist_wininst depends on MBCS codec, unavailable on non-Windows,
and bdist_wininst have not worked since at least Python 3.2, possibly
never on py3k.
Here we document that bdist_wininst is only supported on Windows
and we mark it _unsupported otherwise to skip tests.
Distributors of Python 3 can now safely drop the bdist_wininst .exe files
without the need to skip bdist_wininst related tests.
https://bugs.python.org/issue10945
bdist_wininst depends on MBCS codec, unavailable on non-Windows, and bdist_wininst have not worked since at least Python 3.2, possibly never on py3k.
Here we document that bdist_wininst is only supported on Windows and we mark it _unsupported otherwise to skip tests.
Distributors of Python 3 can now safely drop the bdist_wininst .exe files without the need to skip bdist_wininst related tests.
| @@ -342,6 +341,9 @@ version number. This can be changed to another text by using the |
|---|
| The installer file will be written to the "distribution directory" --- normally |
| :file:`dist/`, but customizable with the :option:`!--dist-dir` option. |
| .. versionchanged:: 3.9 |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this note.
I don't see why this change should be Python 3.9 only: mbcs encoding was never available on platforms other than Windows. If we make a change, I suggest to make it in 3.7, 3.8 and master branches.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gladly 🚀
| @@ -55,6 +56,8 @@ class bdist_wininst(Command): |
|---|
| boolean_options = ['keep-temp', 'no-target-compile', 'no-target-optimize', |
| 'skip-build'] |
| _unsupported = platform.system() != "Windows" |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest:
# bpo-10945: bdist_wininst requires mbcs encoding which is only available on Windows
_unsupported = (sys.platform != "win32")
| @@ -0,0 +1,2 @@ |
|---|
| Officially drop support for creating bdist_wininst installers on non-Windows |
| systems. |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically, it wasn't supported previously, so I don't think that we even have to document the change. But I'm fine with keeping this changelog entry if you prefer.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.
Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
And if you don't make the requested changes, you will be poked with soft cushions!
I have made the requested changes; please review again
Thanks for making the requested changes!
@vstinner: please review the changes made to this pull request.
An idea: Don't install the relevant exe files on non-Windows?
An idea: Don't install the relevant exe files on non-Windows?
I would prefer to have a separated PR for that.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the update.
Thanks @hroncok for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request
bdist_wininst depends on MBCS codec, unavailable on non-Windows, and bdist_wininst have not worked since at least Python 3.2, possibly never on Python 3.
Here we document that bdist_wininst is only supported on Windows, and we mark it unsupported otherwise to skip tests.
Distributors of Python 3 can now safely drop the bdist_wininst .exe files without the need to skip bdist_wininst related tests. (cherry picked from commit 72cd653)
Co-authored-by: Miro Hrončok miro@hroncok.cz
Thanks @hroncok for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request
bdist_wininst depends on MBCS codec, unavailable on non-Windows, and bdist_wininst have not worked since at least Python 3.2, possibly never on Python 3.
Here we document that bdist_wininst is only supported on Windows, and we mark it unsupported otherwise to skip tests.
Distributors of Python 3 can now safely drop the bdist_wininst .exe files without the need to skip bdist_wininst related tests. (cherry picked from commit 72cd653)
Co-authored-by: Miro Hrončok miro@hroncok.cz
miss-islington added a commit that referenced this pull request
bdist_wininst depends on MBCS codec, unavailable on non-Windows, and bdist_wininst have not worked since at least Python 3.2, possibly never on Python 3.
Here we document that bdist_wininst is only supported on Windows, and we mark it unsupported otherwise to skip tests.
Distributors of Python 3 can now safely drop the bdist_wininst .exe files without the need to skip bdist_wininst related tests. (cherry picked from commit 72cd653)
Co-authored-by: Miro Hrončok miro@hroncok.cz
miss-islington added a commit that referenced this pull request
bdist_wininst depends on MBCS codec, unavailable on non-Windows, and bdist_wininst have not worked since at least Python 3.2, possibly never on Python 3.
Here we document that bdist_wininst is only supported on Windows, and we mark it unsupported otherwise to skip tests.
Distributors of Python 3 can now safely drop the bdist_wininst .exe files without the need to skip bdist_wininst related tests. (cherry picked from commit 72cd653)
Co-authored-by: Miro Hrončok miro@hroncok.cz
lisroach pushed a commit to lisroach/cpython that referenced this pull request
bdist_wininst depends on MBCS codec, unavailable on non-Windows, and bdist_wininst have not worked since at least Python 3.2, possibly never on Python 3.
Here we document that bdist_wininst is only supported on Windows, and we mark it unsupported otherwise to skip tests.
Distributors of Python 3 can now safely drop the bdist_wininst .exe files without the need to skip bdist_wininst related tests.
DinoV pushed a commit to DinoV/cpython that referenced this pull request
bdist_wininst depends on MBCS codec, unavailable on non-Windows, and bdist_wininst have not worked since at least Python 3.2, possibly never on Python 3.
Here we document that bdist_wininst is only supported on Windows, and we mark it unsupported otherwise to skip tests.
Distributors of Python 3 can now safely drop the bdist_wininst .exe files without the need to skip bdist_wininst related tests.