[3.6] bpo-23404: make touch becomes make regen-all (#1405) by vstinner · Pull Request #1461 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation2 Commits2 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Don't rebuild generated files based on file modification time
anymore, the action is now explicit. Replace "make touch"
with "make regen-all".

Changes:

• Remove "make touch", Tools/hg/hgtouch.py and .hgtouch
• Add a new "make regen-all" command to rebuild all generated files
• Add subcommands to only generate specific files:
  • regen-ast: Include/Python-ast.h and Python/Python-ast.c
  • regen-grammar: Include/graminit.h and Python/graminit.c
  • regen-importlib: Python/importlib_external.h and Python/importlib.h
  • regen-opcode: Include/opcode.h
  • regen-opcode-targets: Python/opcode_targets.h
  • regen-typeslots: Objects/typeslots.inc
• Rename PYTHON_FOR_GEN to PYTHON_FOR_REGEN
• pgen is now only built by by "make regen-grammar"
• Add $(srcdir)/ prefix to paths to source files to handle correctly
  compilation outside the source directory

Note: $(PYTHON_FOR_REGEN) is no more used nor needed by "make"
default target building Python.
(cherry picked from commit a5c62a8)

Don't rebuild generated files based on file modification time anymore, the action is now explicit. Replace "make touch" with "make regen-all".

Changes:

• Remove "make touch", Tools/hg/hgtouch.py and .hgtouch

• Add a new "make regen-all" command to rebuild all generated files

• Add subcommands to only generate specific files:

  • regen-ast: Include/Python-ast.h and Python/Python-ast.c
  • regen-grammar: Include/graminit.h and Python/graminit.c
  • regen-importlib: Python/importlib_external.h and Python/importlib.h
  • regen-opcode: Include/opcode.h
  • regen-opcode-targets: Python/opcode_targets.h
  • regen-typeslots: Objects/typeslots.inc

• Rename PYTHON_FOR_GEN to PYTHON_FOR_REGEN

• pgen is now only built by by "make regen-grammar"

• Add $(srcdir)/ prefix to paths to source files to handle correctly compilation outside the source directory

Note: $(PYTHON_FOR_REGEN) is no more used nor needed by "make" default target building Python. (cherry picked from commit a5c62a8)

vstinner changed the title[3.5bpo-23404: make touch becomes make regen-all (#1405) [3.6] bpo-23404: make touch becomes make regen-all (#1405)

May 4, 2017

The AST_H_DIR variable was removed from Makefile.pre.in by the commit a5c62a8 (bpo-23404).

AST_H_DIR was hardcoded to "Include", so replace the removed variable by its content.

Remove also ASDLGEN variable from sysconfig example since this variable was also removed. (cherry picked from commit b109a1d)

vstinner added a commit that referenced this pull request

May 5, 2017

• bpo-23404: make touch becomes make regen-all (#1405)

Don't rebuild generated files based on file modification time anymore, the action is now explicit. Replace "make touch" with "make regen-all".

Changes:

• Remove "make touch", Tools/hg/hgtouch.py and .hgtouch

• Add a new "make regen-all" command to rebuild all generated files

• Add subcommands to only generate specific files:

  • regen-ast: Include/Python-ast.h and Python/Python-ast.c
  • regen-grammar: Include/graminit.h and Python/graminit.c
  • regen-importlib: Python/importlib_external.h and Python/importlib.h
  • regen-opcode: Include/opcode.h
  • regen-opcode-targets: Python/opcode_targets.h
  • regen-typeslots: Objects/typeslots.inc

• Rename PYTHON_FOR_GEN to PYTHON_FOR_REGEN

• pgen is now only built by by "make regen-grammar"

• Add $(srcdir)/ prefix to paths to source files to handle correctly compilation outside the source directory

Note: $(PYTHON_FOR_REGEN) is no more used nor needed by "make" default target building Python. (cherry picked from commit a5c62a8)

• bpo-30273: Update sysconfig (#1464)

The AST_H_DIR variable was removed from Makefile.pre.in by the commit a5c62a8 (bpo-23404).

AST_H_DIR was hardcoded to "Include", so replace the removed variable by its content.

Remove also ASDLGEN variable from sysconfig example since this variable was also removed. (cherry picked from commit b109a1d)

(cherry picked from commit 9d02f56)

2 participants