bpo-27679: Remove set_bitfields() by shihai1991 · Pull Request #14648 · python/cpython (original) (raw)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a search of the cpython repository for set_bitfields, this is the only occurrence. This is the initial message in the commit which first created the function 12 years ago: "Make _ctypes_test.c compile on Windows" without any further details or documentation.

If the integrations tests are still fully passing without it and it is not used in any other location, as far as I can tell, it can be safely removed. However, since this is not at all my area of expertise, I don't want to explicitly approve this PR, in case this function is still useful in some way that I'm unaware of. @vstinner would probably have a more definitive answer.