gh-63891: Rename Py_SAFE_DOWNCAST to _Py_DOWNCAST by shihai1991 · Pull Request #15090 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation13 Commits3 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Member

shihai1991 commented

Aug 3, 2019

•

edited by bedevere-appbot

Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not very sure if renaming this would be a good idea and what impact it can have. 🤷‍♂

But I'd like to see the discussion on bug tracker regarding this. Overall the changes look okay to me.

Not very sure if renaming this would be a good idea and what impact it can have.

But I'd like to see the discussion on bug tracker regarding this. Overall the changes look okay to me.

Thanks for review, Sanyam. Waiting enough discussion :)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You cannot remove Py_SAFE_DOWNCAST() macro which is part of the Python stable C ABI.

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Py_SAFE_DOWNCAST

Hi, victor.
Make sure I understand: adding #define _Py_DOWNCAST(VALUE, WIDE, NARROW) Py_SAFE_DOWNCAST(VALUE, WIDE, NARROW) for backwards compatibility and using _Py_DOWNCAST to repalce Py_SAFE_DOWNCAST inside.

ps: docs need updated too.

You PR says:

Rename :meth:Py_SAFE_DOWNCAST to :meth:_Py_DOWNCAST

So it removes Py_SAFE_DOWNCAST() macro. Compilation of any C extension using Py_SAFE_DOWNCAST() will fail with this change.

Make sure I understand: adding #define _Py_DOWNCAST(VALUE, WIDE, NARROW) Py_SAFE_DOWNCAST(VALUE, WIDE, NARROW) for backwards compatibility and using _Py_DOWNCAST to repalce Py_SAFE_DOWNCAST inside.

That would be an option.

You PR says:

Rename :meth:Py_SAFE_DOWNCAST to :meth:_Py_DOWNCAST

So it removes Py_SAFE_DOWNCAST() macro. Compilation of any C extension using Py_SAFE_DOWNCAST() will fail with this change.

Make sure I understand: adding #define _Py_DOWNCAST(VALUE, WIDE, NARROW) Py_SAFE_DOWNCAST(VALUE, WIDE, NARROW) for backwards compatibility and using _Py_DOWNCAST to repalce Py_SAFE_DOWNCAST inside.

That would be an option.

Thanks, victor. I add an alias of Py_SAFE_DOWNCAST and update the news.

Ops, catching an typo erro incidentally: #16230

I have made the requested changes; please review again

Thanks for making the requested changes!

@vstinner: please review the changes made to this pull request.

I'm +0. Removed me from reviewers.

tiran removed their request for review

April 17, 2021 21:15

erlend-aasland changed the titlebpo-19692: Rename Py_SAFE_DOWNCAST to _Py_DOWNCAST gh-63891: Rename Py_SAFE_DOWNCAST to _Py_DOWNCAST

Jan 12, 2024

Closing, as the linked issue is closed.