bpo-21109: Add SafeTarFile by epicfaace · Pull Request #15244 · python/cpython (original) (raw)

Working off of the patch in bpo-21109; adding the tests so that all tests that apply to FileTest also apply to SafeFileTest. It's a bit tricky in this case because of multiple inheritance of the test classes.

https://bugs.python.org/issue21109

epicfaace added 9 commits

August 13, 2019 00:28

[apply safetarfile-4.diff](/python/cpython/pull/15244/commits/7b28c5d2097a4c394a1fe919aa180b66deed86db "apply safetarfile-4.diff")

[7b28c5d](/python/cpython/pull/15244/commits/7b28c5d2097a4c394a1fe919aa180b66deed86db)

[doc: remove duplicate message](/python/cpython/pull/15244/commits/12a50748e9c2c7984963d5bda3669e32eff337b3 "doc: remove duplicate message")

[12a5074](/python/cpython/pull/15244/commits/12a50748e9c2c7984963d5bda3669e32eff337b3)

[add TarFileTest and SafeTarFileTest](/python/cpython/pull/15244/commits/a95ce6ad92d7b404a1c488401a3c140cc851b14a "add TarFileTest and SafeTarFileTest")

[a95ce6a](/python/cpython/pull/15244/commits/a95ce6ad92d7b404a1c488401a3c140cc851b14a)

[test: fix inheritance of tests to make it easier to extend](/python/cpython/pull/15244/commits/a3bcc18b916b33d15fc1b539d9de4340eba239cf "test: fix inheritance of tests to make it easier to extend")

[a3bcc18](/python/cpython/pull/15244/commits/a3bcc18b916b33d15fc1b539d9de4340eba239cf)

[add test inheritance of TarFileTest to all testcases](/python/cpython/pull/15244/commits/2f8990dfdc123c91fb636a123fd12827abf97d92 "add test inheritance of TarFileTest to all testcases")

[2f8990d](/python/cpython/pull/15244/commits/2f8990dfdc123c91fb636a123fd12827abf97d92)

[test: replace tarfile.open with tarfile_open](/python/cpython/pull/15244/commits/769eb3291ab74984acfef53b836af93a92993d0a "test: replace tarfile.open with tarfile_open")

[769eb32](/python/cpython/pull/15244/commits/769eb3291ab74984acfef53b836af93a92993d0a)

[test: replace tarfile.TarFile with self.tarfile_module](/python/cpython/pull/15244/commits/8e522b4155f795df45b1beeae442656c001261d4 "test: replace tarfile.TarFile with self.tarfile_module")

[8e522b4](/python/cpython/pull/15244/commits/8e522b4155f795df45b1beeae442656c001261d4)

[test: make taropen generic](/python/cpython/pull/15244/commits/8f361c11ed2a4c39873332468cb1082d468b9596 "test: make taropen generic")

[8f361c1](/python/cpython/pull/15244/commits/8f361c11ed2a4c39873332468cb1082d468b9596)

[Rename to -base because there's already a class called SafeTarFileTest](/python/cpython/pull/15244/commits/b6862c619e6eaaa187ab3e80e1f545bcd5de1916 "Rename to -base because there's already a class called SafeTarFileTest")

[b6862c6](/python/cpython/pull/15244/commits/b6862c619e6eaaa187ab3e80e1f545bcd5de1916)

the-knights-who-say-ni added the CLA signed label

Aug 13, 2019

bedevere-bot added the awaiting review label

Aug 13, 2019

epicfaace added 6 commits

August 13, 2019 04:44

[Add some tests for SafeTarFile](/python/cpython/pull/15244/commits/bfe20da2aaf56756dbb7e240b41a7d525bd8bb4d "Add some tests for SafeTarFile")

[bfe20da](/python/cpython/pull/15244/commits/bfe20da2aaf56756dbb7e240b41a7d525bd8bb4d)

[test: move safetarfile to another test module](/python/cpython/pull/15244/commits/6011e26ce7b9ab876214c8b479e18a246d2d2282 "test: move safetarfile to another test module")

[6011e26](/python/cpython/pull/15244/commits/6011e26ce7b9ab876214c8b479e18a246d2d2282)

[keep only working safetarfile tests](/python/cpython/pull/15244/commits/18f7b301c842949738404094fe52e4b95e9906e3 "keep only working safetarfile tests")

[18f7b30](/python/cpython/pull/15244/commits/18f7b301c842949738404094fe52e4b95e9906e3)

[add ustarreadtests](/python/cpython/pull/15244/commits/c58262bf184752b82559f18f227de511965062ab "add ustarreadtests")

[c58262b](/python/cpython/pull/15244/commits/c58262bf184752b82559f18f227de511965062ab)

[enable one failing safetarfile test](/python/cpython/pull/15244/commits/b3fa18aa3a53329639f6666afb035e6605975c3a "enable one failing safetarfile test")

[b3fa18a](/python/cpython/pull/15244/commits/b3fa18aa3a53329639f6666afb035e6605975c3a)

[Update tarfile.rst](/python/cpython/pull/15244/commits/14b88fe7e1a1af7978dc818b959e6b3a51cf6834 "Update tarfile.rst")

[14b88fe](/python/cpython/pull/15244/commits/14b88fe7e1a1af7978dc818b959e6b3a51cf6834)

DanielGarcia mannequin mentioned this pull request

Apr 10, 2022

tarfile: Traversal attack vulnerability#65308

Closed

ezio-melotti removed the CLA signed label

Jul 13, 2022

Copy link Copy Markdown

Member

encukou commented

Jun 19, 2025

Superseded by PEP-706. A safe(r) option is now the default.
Thank you for this attempt!

encukou closed this

Jun 19, 2025

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Reviewers

ethanfurman Awaiting requested review from ethanfurman ethanfurman will be requested when the pull request is marked ready for review ethanfurman is a code owner