bpo-30336: Create PULL_REQUEST_TEMPLATE.md by raven0034 · Pull Request #1539 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation3 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

raven0034

The community needs to be able to prove that their contributions work, so I've added a template to guide them along the way. May need rebase merging.

@raven0034

@the-knights-who-say-ni

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA. This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@raven0034 raven0034 changed the titleCreate PULL_REQUEST_TEMPLATE.md BPO-30336 Create PULL_REQUEST_TEMPLATE.md

May 10, 2017

@raven0034 raven0034 changed the titleBPO-30336 Create PULL_REQUEST_TEMPLATE.md bpo-30336 Create PULL_REQUEST_TEMPLATE.md

May 10, 2017

@brettcannon brettcannon changed the titlebpo-30336 Create PULL_REQUEST_TEMPLATE.md bpo-30336: Create PULL_REQUEST_TEMPLATE.md

May 10, 2017

@raven0034

Why has this been closed?

@encukou

See the linked issue. Discussion about whether something is a good idea at all generally happens on the bug tracker, leaving GitHub pull requests for reviewing the details of implementation.

Takeaway from Victor & Brett:

I feel that you have useful hints for new contributors, but I suggest you to enhance the devguide instead of using a template.
If you do want to file issues or PRs against the devguide, the repo is at https://github.com/python/devguide.