cpython (original) (raw)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No offence taken 😄

I find variable declarations in an if statement pretty ugly

As far as I know, it's considered good practice for declarations to be limited to the scope of the blocks where they're used, as long as the version of C in use permits it. There's nothing special about an if block here - one would do the same for for, while, do etc.

I won't bother making a separate commit for it

I wouldn't worry too much about that; commits are cheap and would normally be squashed on merge, anyway.