bpo-30380: Pin the version of Sphinx used to build the documentation by Mariatta · Pull Request #1612 · python/cpython (original) (raw)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might be better to specify the version in .travis.yml and leave the Makefile alone. My thinking is that locking Travis for testing makes sure it stays green and it's obvious what we are requiring for CI to pass, but leaving the Makefile alone makes it easier to update the docs to the latest version of Sphinx offline.

Python 2.7 also doesn't have the venv command in the Makefile but it does have the explicit pip call in .travis.yml.

Or maybe I'm just nuts and that logic is flawed. 😄