bpo-28556: Update the opening note in typing docs by ilevkivskyi · Pull Request #16204 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation5 Commits2 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

ilevkivskyi

This PR replaces the old note mentioning that typing is a provisional module with a new one mentioning types are not enforced at runtime. I am not sure if there was any official announcement about making typing non-provisional, but de-facto no new features were added during Python 3.7, and no backwards incompatible changes were made except for few small things that were considered bugs.

https://bugs.python.org/issue28556

@ilevkivskyi

gvanrossum

:term:`provisional basis `. New features might
be added and API may change even between minor releases if deemed
necessary by the core developers.
Python runtime does not enforce the function and variable type annotations.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Python runtime does not enforce the function and ...

@ilevkivskyi

gvanrossum

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't recall exactly how it became non-provisional, I think we already bent the rules for provisional modules by keeping it provisional longer than one release cycle. :-)

@miss-islington

Thanks @ilevkivskyi for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Sep 16, 2019

@ilevkivskyi @miss-islington

This PR replaces the old note mentioning that typing is a provisional module with a new one mentioning types are not enforced at runtime. I am not sure if there was any official announcement about making typing non-provisional, but de-facto no new features were added during Python 3.7, and no backwards incompatible changes were made except for few small things that were considered bugs. (cherry picked from commit 81528ba)

Co-authored-by: Ivan Levkivskyi levkivskyi@gmail.com

@bedevere-bot

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Sep 16, 2019

@ilevkivskyi @miss-islington

This PR replaces the old note mentioning that typing is a provisional module with a new one mentioning types are not enforced at runtime. I am not sure if there was any official announcement about making typing non-provisional, but de-facto no new features were added during Python 3.7, and no backwards incompatible changes were made except for few small things that were considered bugs. (cherry picked from commit 81528ba)

Co-authored-by: Ivan Levkivskyi levkivskyi@gmail.com

@bedevere-bot

miss-islington added a commit that referenced this pull request

Sep 16, 2019

@miss-islington @ilevkivskyi

This PR replaces the old note mentioning that typing is a provisional module with a new one mentioning types are not enforced at runtime. I am not sure if there was any official announcement about making typing non-provisional, but de-facto no new features were added during Python 3.7, and no backwards incompatible changes were made except for few small things that were considered bugs. (cherry picked from commit 81528ba)

Co-authored-by: Ivan Levkivskyi levkivskyi@gmail.com

miss-islington added a commit that referenced this pull request

Sep 16, 2019

@miss-islington @ilevkivskyi

This PR replaces the old note mentioning that typing is a provisional module with a new one mentioning types are not enforced at runtime. I am not sure if there was any official announcement about making typing non-provisional, but de-facto no new features were added during Python 3.7, and no backwards incompatible changes were made except for few small things that were considered bugs. (cherry picked from commit 81528ba)

Co-authored-by: Ivan Levkivskyi levkivskyi@gmail.com

JelleZijlstra added a commit to python/peps that referenced this pull request

May 1, 2021

@JelleZijlstra

PEP 484 is still marked as "Provisional", but as @Fidget-Spinner pointed out in python/typing#805, it shouldn't be any more. python/cpython#16204 removed talk about typing's provisional status from the module docs, and enhancements to typing have been in the form of new PEPs for the last few release cycles.

Going to mark this as a draft so Guido can have a chance to comment once he's back.