bpo-13691: Fixes pydoc help (or help('help')) to show the doc for help by CuriousLearner · Pull Request #172 · python/cpython (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation4 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
This is an attempt to fix issue http://bugs.python.org/issue13691
This is another approach which we could take to resolve the issue around the use of help.
Otherwise we could define a protocol such as introducing __help__ magic method as Nick suggested on the bug.
Please let me know if this needs changes :)
Hello, and thanks for your contribution!
I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).
Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow these steps to rectify the issue:
- Sign the PSF contributor agreement
- Wait at least one US business day and then check "Your Details" on bugs.python.org to see if your account has been marked as having signed the CLA (the delay is due to a person having to manually check your signed CLA)
- Reply here saying you have completed the above steps
Thanks again to your contribution and we look forward to looking at it!
CLA is signed and now visible in my account.
cc @ncoghlan
Sorry for taking so long to review this @CuriousLearner.
I'm afraid I really don't like the notion of making pydoc natively aware of _sitebuiltins._Helper - that's two distinct cases of coupling a general purpose module shared across Python implementations to interpreter implementation details that aren't guaranteed to exist outside of CPython.
Added the sprint label, as this PR was submitted at the PyCon Pune 2017 core development sprint.
jaraco pushed a commit that referenced this pull request
