bpo-36470: Allow dataclasses.replace() to work InitVar with default values by PCManticore · Pull Request #17441 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation9 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

PCManticore

If a dataclass contain an InitVar, that InitVar must be specified in the call to replace(), unless it has a default value, in which case replace() should not raise a ValueError if the value was not specified in the call to replace().

https://bugs.python.org/issue36470

ericvsmith

@bedevere-bot

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@PCManticore

…alues

If a dataclass contain an InitVar, that InitVar must be specified in the call to replace(), unless it has a default value, in which case replace() should not raise a ValueError if the value was not specified in the call to replace(). Patch by Claudiu Popa.

@PCManticore

Hi @ericvsmith

Thank you for the review! Sorry about that print, should have double checked before sending it in.

I have made the requested changes; please review again.

@bedevere-bot

Thanks for making the requested changes!

@ericvsmith: please review the changes made to this pull request.

@anthrotype

I see https://bugs.python.org/issue36470 is still open. Why was this PR closed without a merge?
The issue makes using dataclasses.replace impossible with InitVars that have default values (which I believe is quite common).
Please consider reopening this, thank you

@ericvsmith

I don't know why it was closed. I'll try and take a look at the bpo.

@cadiv

any news on this? I just hit this issue myself and wound up here