[3.8] bpo-39016: type_mro_modified produces negative refcount by ctismer · Pull Request #17555 · python/cpython (original) (raw)

No guys, this "if (custom)" part is only in the 3.8 branch.

Would it make any sense to reuse master code in 3.8?

No idea. I was not aware that 3.8 and master diverge that much. Should the "if (custom) {" clause perhaps be adjusted/removed like in master?

Update: master is probably a bit behind Python 3.8, see the comment in type_mro_modified. So I would probably use the corrected 3.8 version (no Py_XDECREF's) and apply it to master as well.

It was a change by Julien Palard from 2019-05-26, 180dc1b
Not sure why that did not go into master. Was added with good intention but bad refcounting ;-)