gh-64383: Migrate builtins.vars and builtins.dir to Argument Clinic by shihai1991 · Pull Request #18512 · python/cpython (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation6 Commits2 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Sorry this had to wait for so long! If you're still interested, would you be able to fix the merge conflicts? Then I can review it and get it merged.
Sorry this had to wait for so long! If you're still interested, would you be able to fix the merge conflicts? Then I can review it and get it merged.
Oh, Thanks. Give me some time to take a look. I forget the details already :(
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting changes for fixing the conflicts, as per above
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.
Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
bpo-20184: Migrate builtins.vars and builtins.dir to Argument Clinic gh-64383: Migrate builtins.vars and builtins.dir to Argument Clinic
