cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation12 Commits30 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Co-Authored-By: Victor Stinner vstinner@python.org

…test:

tkinter/test distutils/tests ctypes/tests lib2to3/tests sqlite3/test unittest/test

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure that tests still run correctly when running from an installed instance of Python, not just from a development build directory. The various test directories are installed in the main Makefile (Makefile.pre.in) libinstall rule. I think you'll find that many tests are now broken. See the LIBSUBDIRS variable in the Makefile. (I see that the dev guide does not refer to this topic so I've opened a devguide issue about it: python/devguide#573)

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Thanks @ned-deily , I've updated the makefile and adding a News file.
I have made the requested changes; please review again

Thanks for making the requested changes!

@ned-deily: please review the changes made to this pull request.

… into bpo-10572-reArranging_Lib_tests

Ok I fixed all of the tests expect 1 in lib2to3 in which I'm not really sure what's going on.

When looking on the test that's failing:

test_write_filtered_python_package (test.test_zipfile.PyZipFileTests) ... File "/Users/runner/runners/2.164.0/work/cpython/cpython/Lib/test/lib2to3_tests/data/bom.py", line 2
print "BOM BOOM!"

It looks like it uses print syntax of python 2.7 which is not relevant anymore, any idea why is it there? I suspect in the master it was just not running and because now it's in the tests folder it's running by default.

I have made the requested changes; please review again

Thanks for making the requested changes!

@ned-deily: please review the changes made to this pull request.

@idomic it looks like it's a test file for the lib2to3 test to use. There's probably a test that reads that file, runs lib2to3 on it, and checks the results. So that file is very likely there on purpose and meant to be Python 2 syntax.

@idomic you also have conflicts. It might be easier to do one PR per package so lessen the chances of merge conflicts occurring.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The merge conflicts need to be fixed, and I would strongly suggest breaking this PR up into single PRs per package.

The merge conflicts need to be fixed, and I would strongly suggest breaking this PR up into single PRs per package.

I'll submit a new PR with 1 package and will tag you and Ned