bpo-27115: Use Query subclass for IDLE editor Goto by terryjreedy · Pull Request #18871 · python/cpython (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation9 Commits9 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
This checks entry errors without closing the box.
| "Get a positive line number for editor Go To Line." |
|---|
| # Used in editor.EditorWindow.goto_line_event. |
| def __init__(self, parent, title, message, *, _htest=False, _utest=False): |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This __init__ seems unnecessary.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, I copied and edited from an existing subclass that does need it. Deleted.
| text.bell() |
|---|
| return "break" |
| lineno = query.Goto( |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this behave correctly when simply closing the dialog?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. Cursor stays put but selection is erroneously cleared. Fixed.
| @@ -3,6 +3,9 @@ Released on 2020-10-05? |
|---|
| ====================================== |
| bpo-27115: For Edit Go to Line, use a Query entry box subclass with |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Edit Go to Line" is a bit awkward; IMO "Go to Line" is sufficient and clearer.
(Relevant to the NEWS entry as well.)
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed. Thank you for the comments.
Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request
Replace tkinter tkSimpleDialog.askinteger with a standard IDLE query dialog. The new box checks for positivity before returning. (cherry picked from commit 363fab8)
Co-authored-by: Terry Jan Reedy tjreedy@udel.edu
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request
Replace tkinter tkSimpleDialog.askinteger with a standard IDLE query dialog. The new box checks for positivity before returning. (cherry picked from commit 363fab8)
Co-authored-by: Terry Jan Reedy tjreedy@udel.edu
miss-islington added a commit that referenced this pull request
Replace tkinter tkSimpleDialog.askinteger with a standard IDLE query dialog. The new box checks for positivity before returning. (cherry picked from commit 363fab8)
Co-authored-by: Terry Jan Reedy tjreedy@udel.edu
miss-islington added a commit that referenced this pull request
Replace tkinter tkSimpleDialog.askinteger with a standard IDLE query dialog. The new box checks for positivity before returning. (cherry picked from commit 363fab8)
Co-authored-by: Terry Jan Reedy tjreedy@udel.edu