bpo-19468: delete unnecessary instance check in importlib.reload() by furkanonder · Pull Request #19424 · python/cpython (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation12 Commits3 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
bpo:19468 delete unnecessary modul control statement bpo-19468: delete unnecessary modul control statement
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
IMO news could be skipped.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I expect there could possibly be some deep corner cases (via _bootstrap._find_spec() and _bootstrap._exec() that would change behavior here, but find it highly unlikely that, if such cases even exist, anyone relies on them. 😄
bpo-19468: delete unnecessary modul control statement bpo-19468: delete unnecessary instance check in importlib.reload()
LGTM, although I think a news entry is still appropriate.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a news entry as it changes the semantics of the function.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.
Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
@furkanonder please read the instructions from the bot on how to signal you're ready for another review.
@furkanonder please read the instructions from the bot on how to signal you're ready for another review.
Sorry, I missed it. I have made the requested changes; please review again :)
arun-mani-j pushed a commit to arun-mani-j/cpython that referenced this pull request
