bpo-31904: Increase LOOPBACK_TIMEOUT to 10 for VxWorks RTOS by pxinwr · Pull Request #19447 · python/cpython (original) (raw)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks a bit odd to see:

elif sys.platform == 'vxworks':
LOOPBACK_TIMEOUT = 10

but I suppose adding an OR after the existing AND condition would also be awkward. I'll leave it to your (or someone else's) judgment.

(Especially) if you are going to keep it a separate clause, I would like to see a comment explaining why. For instance, "vxworks is used on embedded devices, and some boards are quite slow; avoid false alarms"