bpo-40443: Remove unused imports in idlelib by vstinner · Pull Request #19801 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation8 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

vstinner

@vstinner

@vstinner

terryjreedy

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-use verified.

@terryjreedy

Don't understand macOS failure, and the abrupt stop. Treating as unrelated intermittent failure.

clang: warning: -framework Tk: 'linker' input unused [-Wunused-command-line-argument]
In file included from /Users/runner/runners/2.169.1/work/cpython/cpython/Modules/_tkinter.c:46:
/Applications/Xcode_11.3.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/tk.h:86:11: fatal error: 'X11/Xlib.h' file not found
#       include <X11/Xlib.h>
                ^~~~~~~~~~~~
1 error generated.

Python build finished successfully!

...
The following modules found by detect_modules() in setup.py, have been

...

@miss-islington

Thanks @vstinner for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington

Thanks @vstinner for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Apr 30, 2020

@vstinner @miss-islington

(cherry picked from commit 6900f16)

Co-authored-by: Victor Stinner vstinner@python.org

@bedevere-bot

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Apr 30, 2020

@vstinner @miss-islington

(cherry picked from commit 6900f16)

Co-authored-by: Victor Stinner vstinner@python.org

@bedevere-bot

miss-islington added a commit that referenced this pull request

Apr 30, 2020

@miss-islington @vstinner

(cherry picked from commit 6900f16)

Co-authored-by: Victor Stinner vstinner@python.org

miss-islington added a commit that referenced this pull request

Apr 30, 2020

@miss-islington @vstinner

(cherry picked from commit 6900f16)

Co-authored-by: Victor Stinner vstinner@python.org

@vstinner vstinner deleted the remove_unused_imports_idle branch

April 30, 2020 09:29

@vstinner

Terry: yeah sadly the macOS CI looks sick :-(