bpo-26407: Do not mask errors in csv. by serhiy-storchaka · Pull Request #20536 · python/cpython (original) (raw)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with directly raising other exceptions from __iter__ rather than suppressing them w/ TypeError, as it can easily obfuscate bugs. The more general discussion will likely have to take place somewhere like python-dev, but for now, I think changing csv.writerow() has a narrow enough scope.

+1, other than a comment/question on the C changes.