bpo-41205: Document Decimal power 0 to the 0 by srinivasreddy · Pull Request #21386 · python/cpython (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation14 Commits5 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. One nitpicky request to remove the extra blank lines introduced in this PR, and one suggested minor wording change.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.
Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
Co-authored-by: Mark Dickinson dickinsm@gmail.com
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates! LGTM. I'll leave this open for a bit in case @skrah or @rhettinger wants to comment.
| @@ -1355,7 +1355,9 @@ In addition to the three supplied contexts, new contexts can be created with the |
|---|
| must be integral. The result will be inexact unless ``y`` is integral and |
| the result is finite and can be expressed exactly in 'precision' digits. |
| The rounding mode of the context is used. Results are always correctly-rounded |
| in the Python version. |
| in the Python version. ``Decimal(0) ** Decimal(0)`` results in |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a blank line so this gets its own paragraph.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.
Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
@rhettinger's comment has been addressed, so I think we can merge.
Thanks @srinivasreddy for the PR, and @skrah for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request
Co-authored-by: Mark Dickinson dickinsm@gmail.com (cherry picked from commit 10e4664)
Co-authored-by: Srinivas Reddy Thatiparthy (శ్రీనివాస్ రెడ్డి తాటిపర్తి) thatiparthysreenivas@gmail.com
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request
Co-authored-by: Mark Dickinson dickinsm@gmail.com (cherry picked from commit 10e4664)
Co-authored-by: Srinivas Reddy Thatiparthy (శ్రీనివాస్ రెడ్డి తాటిపర్తి) thatiparthysreenivas@gmail.com
miss-islington added a commit that referenced this pull request
Co-authored-by: Mark Dickinson dickinsm@gmail.com (cherry picked from commit 10e4664)
Co-authored-by: Srinivas Reddy Thatiparthy (శ్రీనివాస్ రెడ్డి తాటిపర్తి) thatiparthysreenivas@gmail.com
miss-islington added a commit that referenced this pull request
Co-authored-by: Mark Dickinson dickinsm@gmail.com (cherry picked from commit 10e4664)
Co-authored-by: Srinivas Reddy Thatiparthy (శ్రీనివాస్ రెడ్డి తాటిపర్తి) thatiparthysreenivas@gmail.com
arun-mani-j pushed a commit to arun-mani-j/cpython that referenced this pull request
Co-authored-by: Mark Dickinson dickinsm@gmail.com
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request
Co-authored-by: Mark Dickinson dickinsm@gmail.com
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request
Co-authored-by: Mark Dickinson dickinsm@gmail.com
xzy3 pushed a commit to xzy3/cpython that referenced this pull request
Co-authored-by: Mark Dickinson dickinsm@gmail.com
