bpo-31904: fix test_doctest.py failures for VxWorks by pxinwr · Pull Request #23419 · python/cpython (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation10 Commits4 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
In test_CLI(), "print(normalize(err))" expects "No such file" which has the first letter n as capital. However VxWorks outputs 'no such file with the first letter n as lower case. So tuned accordingly.
https://bugs.python.org/issue31904
Is there a publicly and freely available VxWorks VM image that one could use to test this?
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.
Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
I have made the requested changes; please review again
Thanks for making the requested changes!
@gpshead: please review the changes made to this pull request.
Thanks for the update @pxinwr and thanks @gpshead for merging the change ;-)
adorilson pushed a commit to adorilson/cpython that referenced this pull request
Fix test_doctest.py failures for VxWorks by avoiding exact error message checks. (better for everyone all around)
Labels
Tests in the Lib/test dir