bpo-22295: use python -m pip rather than plain pip in examples by scop · Pull Request #24003 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation10 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The examples already in a virtual environment should not be changed because the whole point of the environment is to make sure the correct python and pip are being targeted.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can revert those if that's what it takes to get this merged (please confirm), but would like to point out first that

• they will then be the only places referring to the pip executable rather than python -m pip which might be a surprise to some readers, it gets more rare and there's no explanation for it, and
• the point of using python -m pip instead of pip is just as valid in virtual envs as it is outside of them

This PR is stale because it has been open for 30 days with no activity.

Pending @rhettinger comments above, not stale as far as I'm concerned.

This PR is stale because it has been open for 30 days with no activity.

Still not stale I think, see above.

scop changed the titleDoc: use python -m pip rather than plain pip in examples [bpo-22295](https://bugs.python.org/issue22295) use python -m pip rather than plain pip in examples

Feb 14, 2022

Please edit the PR title to begin with [bpo-22295](https://bugs.python.org/issue22295):

devguide.python.org/pullrequest/#submitting

Oops, the bot edited my comment to add a Markdown link, I meant just the xyz-12345 bit :)

scop changed the title[bpo-22295](https://bugs.python.org/issue22295) use python -m pip rather than plain pip in examples bpo-22295: use python -m pip rather than plain pip in examples

Apr 9, 2022

Tweaked title, resolved conflicts.

LGTM. Now all examples consistently use python -m pip. Thanks, @scop, for the PR and, @hugovk, for nudging it along.

scop deleted the python-m-pip branch

April 9, 2022 19:23

guyer added a commit to guyer/fipy that referenced this pull request

May 13, 2022

guyer added a commit to usnistgov/fipy that referenced this pull request

May 20, 2022