bpo-43888: Remove coverage builds from CI by ammaraskar · Pull Request #25679 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

ammaraskar

We introduced code coverage a while ago as part of https://bugs.python.org/issue23721 and python/core-workflow#2 but it looks like this feature isn't really utilized by many people based on searching for "codecov" on github and bpo. These builds take way longer due to the instrumentation and this is cutting into valuable CI time. The builds are now also failing on master with the new timeout mechanism.

Let's just get rid of the coverage builds and see if anyone complains :)

https://bugs.python.org/issue43888

@ammaraskar

brettcannon

@brettcannon

Before this can be merged there are probably some changes required over on the devguide to go with this.

@ammaraskar are you up to do a PR for that? We should probably drop the devguide mentions before we actually drop things.

@ammaraskar

Sounds good, let me check up on what changes need to be made in the devguide.

@vstinner

I never used this feature.

@ammaraskar

Brett, the only mention I found in the devguide about coverage that seemed relevant to codecov was in the committing checklist, I made a PR for that here: python/devguide#685

The rest is a guide on how to determine coverage locally which should stay in the devguide.

@Mariatta

DevGuide PR has been merged. Thanks.

@brettcannon

@RodrigoDornelles

I missed it the same day, but now I had time to mention it, I usually check the coverage status to analyze and study more about construct languages.

@hugovk

This missed Misc/requirements-test.txt, please see #110240 to remove it.

This was referenced

Feb 24, 2024