gh-85283: Extending Argument Clinic to support to use the limited C API. by shihai1991 · Pull Request #26080 · python/cpython (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation14 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Before I look at the patch: what is the purpose of it? Argument Clinic is an internal tool for CPython, it can use the full API.
This PR is stale because it has been open for 30 days with no activity.
This comment was marked as off-topic.
| @@ -887,7 +895,7 @@ def parser_body(prototype, *fields, declarations=''): |
|---|
| """, indent=4)] |
| else: |
| parser_code = [normalize_snippet(""" |
| if (!PyArg_ParseTuple(args, "{format_units}:{name}", |
| if (!_PyArg_ParseTupleAndKeywordsFast(args, kwargs, &_parser, |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the limited C API when using the use_limited_api flag, otherwise it'll use the unlimited C API.
Sorry for my delay.
| else: |
|---|
| declarations = ( |
| 'static const char * const _keywords[] = {{{keywords} NULL}};\n' |
| 'static _PyArg_Parser _parser = {{"{format_units}:{name}", _keywords, 0}};') |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not in the Limited API.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, you are right. Thanks.
This was referenced
Nov 3, 2022
bpo-41111: Extending Argument Clinic to support to use the limited C API. gh-85283: Extending Argument Clinic to support to use the limited C API.
After PEP 620 canceled, so I decide close this PR. I will reopen this PR when we continue update PEP 620, ref: python/peps#2923
Thanks Mike, Serhiy for your review.
@vstinner would of course know best, but my impression of the intent of withdrawing PEP 620 was that neither would it be re-opened and updated later or nor would the remaining changes be abandoned (as most of them were completed or mostly completed already), but rather they would be broken up into smaller separate PEPs.
@shihai1991, are you interested in reviving this effort?
@shihai1991, are you interested in reviving this effort?
Sure, of course. Sorry for my late replay ;)