bpo-30886: Fix multiprocessing.Queue.join_thread() by vstinner · Pull Request #2642 · python/cpython (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation5 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
multiprocessing.Queue.join_thread() now waits until the thread
completes, even if the thread was started by the same process which
created the queue.
Fix the following warning which occurs randomly when running
test_handle_called_with_mp_queue of test_logging.QueueListenerTest:
Warning -- threading_cleanup() failed to cleanup -1 threads after 4 sec (count: 0, dangling: 1)
Sorry, I don't understand well the purpose of created_by_this_process, so I didn't write a proper commit message yet.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs a NEWS blurb, otherwise looks ok to me.
multiprocessing.Queue.join_thread() now waits until the thread completes, even if the thread was started by the same process which created the queue.
Fix the following warning which occurs randomly when running test_handle_called_with_mp_queue of test_logging.QueueListenerTest:
Warning -- threading_cleanup() failed to cleanup -1 threads after 4 sec (count: 0, dangling: 1)
This needs a NEWS blurb, otherwise looks ok to me.
Ok, done.
vstinner added a commit that referenced this pull request
multiprocessing.Queue.join_thread() now waits until the thread completes, even if the thread was started by the same process which created the queue.
Fix the following warning which occurs randomly when running test_handle_called_with_mp_queue of test_logging.QueueListenerTest:
Warning -- threading_cleanup() failed to cleanup -1 threads after 4 sec (count: 0, dangling: 1) (cherry picked from commit 3b69d91)
vstinner added a commit that referenced this pull request
multiprocessing.Queue.join_thread() now waits until the thread completes, even if the thread was started by the same process which created the queue.
Fix the following warning which occurs randomly when running test_handle_called_with_mp_queue of test_logging.QueueListenerTest:
Warning -- threading_cleanup() failed to cleanup -1 threads after 4 sec (count: 0, dangling: 1) (cherry picked from commit 3b69d91)