bpo-39452: rewrite and expand main.rst by jdevries3133 · Pull Request #26883 · python/cpython (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation99 Commits51 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
I am picking up the torch on 39452, continuing where @maggyero left off, and
also implementing
my discourse proposal,
which seemed to be well-liked.
- __main__docs: intro and first secton
- bpo-44494: rewrite of Doc/library/__main__.rst (first draft)
- bpo-44494: add blurb
- Update __main__.rst
- Update __main__.rst
- Take Steven d’Aprano’s review into account
- Rewrap lines
- Remove trailing whitespaces
https://bugs.python.org/issue39452
- Related bpo's: 17359, 24632, 38452
is it worth mentioning runpy?
is it work mentioning runpy?
I think so! It's been mentioned; see 4c60f2c
OK, at this point I made all the edits I wanted. Look like @merwok did a pass on that already. If I don't hear back by end of day today, I'll be merging that. Huge improvement over the status quo, thanks for your hard work @jdevries3133.
I have noted various small things, but don’t have the time to do an overarching review of all changes.
So I’m glad you picked up my request for review and did an editing pass so that this contribution can be merged! Thanks for your and Jack’s efforts on this!
Thanks @jdevries3133 for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖
@ambv: Please replace # with GH- in the commit message next time. Thanks!
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request
Broadened scope of the document to explicitly discuss and differentiate between __main__.py in packages versus the __name__ == '__main__' expression (and the idioms that surround it), as well as import __main__.
Co-authored-by: Géry Ogam gery.ogam@gmail.com Co-authored-by: Éric Araujo merwok@netwok.org Co-authored-by: Łukasz Langa lukasz@langa.pl (cherry picked from commit 7cba231)
Co-authored-by: Jack DeVries 58614260+jdevries3133@users.noreply.github.com
miss-islington added a commit that referenced this pull request
Broadened scope of the document to explicitly discuss and differentiate between __main__.py in packages versus the __name__ == '__main__' expression (and the idioms that surround it), as well as import __main__.
Co-authored-by: Géry Ogam gery.ogam@gmail.com Co-authored-by: Éric Araujo merwok@netwok.org Co-authored-by: Łukasz Langa lukasz@langa.pl (cherry picked from commit 7cba231)
Co-authored-by: Jack DeVries 58614260+jdevries3133@users.noreply.github.com
Labels
Documentation in the Doc dir