bpo-30935: update get_event_loop docs by daxlab · Pull Request #2731 · python/cpython (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation16 Commits2 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
@daxlab, thanks for your PR! By analyzing the history of the files in this pull request, we identified @birkenfeld to be a potential reviewer.
| @@ -165,7 +165,7 @@ An event loop policy must implement the following interface: |
|---|
| .. method:: get_event_loop() |
| Get the event loop for the current context. |
| Get the event loop for the current coroutine. |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You want to say this not in the documentation of the interface, but in the documentation of the default policy.
Also, in the bpo issue I suggested adding a "Changed in 3.6" directive, but I don't see that here.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't it already there ?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In "What's New," yes, but not in the asyncio section of the docs.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the "Changed in 3.6" directive as suggested by @cjerdonek
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.
Once you have made the requested changes, please leave a comment on this pull request containing the phrase I didn't expect the Spanish Inquisition!. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
add version changed directive
I didn't expect the Spanish Inquisition!
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still doesn't update the get_event_loop() docs as I said in the original bpo issue and in my previous review comment.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.
Once you have made the requested changes, please leave a comment on this pull request containing the phrase I didn't expect the Spanish Inquisition!. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
Please update the docstring of get_event_loop()
@daxlab There were some additional changes requested since your last commit. Would you be able to take a look at those? Thanks!
1st1 approved these changes May 29, 2018
Thanks @daxlab for the PR, and @1st1 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request
(cherry picked from commit e55de2d)
Co-authored-by: Mandeep Singh daxlab@users.noreply.github.com
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request
(cherry picked from commit e55de2d)
Co-authored-by: Mandeep Singh daxlab@users.noreply.github.com
miss-islington added a commit that referenced this pull request
(cherry picked from commit e55de2d)
Co-authored-by: Mandeep Singh daxlab@users.noreply.github.com
miss-islington added a commit that referenced this pull request
(cherry picked from commit e55de2d)
Co-authored-by: Mandeep Singh daxlab@users.noreply.github.com