bpo-31009: Fix support.fd_count() on Windows by vstinner · Pull Request #2862 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation5 Commits2 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

On Windows, test.support.fd_count() now calls
msvcrt.CrtSetReportMode() to not kill the process nor log any error
on stderr on os.dup(fd) if the file descriptor is invalid.

https://bugs.python.org/issue31009

I tested manually: test_child_fd_inflation() of test_multiprocessing_spawn doesn't hang anymore on a debug build on Windows. Moreover, test_regrtest still pass.

" continuous-integration/appveyor/pr — AppVeyor was unable to build non-mergeable pull request" I don't understand this error :-( My commit is just on top on master. I updated my local Git clone, there is no new commt in master.

I ran manually the test suite on Windows: all tests pass. To be honest, test_distutils fails, but it's unrelated to this change and I don't know how to fix my Windows support to get a working C compiler...

On Windows, test.support.fd_count() now calls msvcrt.CrtSetReportMode() to not kill the process nor log any error on stderr on os.dup(fd) if the file descriptor is invalid.

Crap, there was a whitespace issue... "Fixing Python file whitespace ... 1 file: Lib/test/support/init.py". It's now fixed.

Travis CI failed on downloading Python 3.6 on the docs job :-(

Downloading archive: https://s3.amazonaws.com/travis-python-archives/binaries/ubuntu/14.04/x86_64/3.6-python.tar.bz2
$ sudo tar xjf python-3.6.tar.bz2 --directory /
bzip2: (stdin) is not a bzip2 file.

2 participants