bpo-28206: Document signals Handlers, Sigmasks and Signals enums by Bibo-Joshi · Pull Request #28628 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation4 Commits4 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Hi @Bibo-Joshi, thanks for working on it. Could you please rebase your commit on top of main?

You may have worked on an old clone, and based your commit on a commit from 2018.

Updates the example and adds documentation for the enums signal.{Signals, Handlers, Sigmasks}

Hi @JulienPalard. I based my branch on the branch of #1939, that's why these old commits where there. I've rebased onto main and force-pushed - the diff should be the same.
If you want me to instead squash the old commits & my new commit together, I can do that as well :)

Thanks for rebasing! There's no need to squash in the cpython repository as when we merge a PR, we always squash and merge (probably badly named, it's more a "rebase, squash, and commit"), so the git log of the main branch is always nice and clean.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM