bpo-10716: Migrating pydoc to html5. by JulienPalard · Pull Request #28651 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation29 Commits5 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

I tried myself at porting pydoc to html5.

I though (hoped?) the commit would be smaller, I tried to keep it as small as possible. I did not tried to enhance the graphical result, I just focused on HTML modernisation as a fist step.

https://bugs.python.org/issue10716

Ohhh, interesting, cgitb depends on pydoc, so if I use css in pydoc... oh wow.

So I modified cgitb a bit to not depend on html rendered by pydoc.

I also had to modify pydoc test which were extremely strict in the output expected, I tried to still check that every bit of important info are given, while not being strict on the HTML used.

TIL about ServerHTMLDoc...

I'd like to merge this, does someone still want to proof-read first?

I haven’t had a chance to run it locally to see the results yet.
Maybe you have screenshots?

This could get a note in the release notes (for pydoc and xmlrpc — cgitb is unchanged)

Here come the screenshots, side by side:

There's a few differences, in the height of the title bar for example.

This could get a note in the release notes (for pydoc and xmlrpc — cgitb is unchanged)

True, done.

Thank you for your efforts in tackling this! It was needed and is the basis for future improvements.

I have added some final questions on some details. (If you make changes, please avoid force-pushing to make reviewing easier.)