bpo-31034: Reliable signal handler for test_asyncio by vstinner · Pull Request #2867 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation6 Commits2 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

vstinner

@vstinner

Don't rely on the current SIGHUP signal handler, make sure that it's set to the "default" signal handler: SIG_DFL.

@vstinner

@brettcannon brettcannon changed the titlebpo-31034: Reliable signal handler for test_asyncio Reliable signal handler for test_asyncio

Jul 25, 2017

@brettcannon brettcannon changed the titleReliable signal handler for test_asyncio bpo-31034: Reliable signal handler for test_asyncio

Jul 25, 2017

@brettcannon brettcannon changed the titlebpo-31034: Reliable signal handler for test_asyncio Reliable signal handler for test_asyncio

Jul 25, 2017

@brettcannon brettcannon changed the titleReliable signal handler for test_asyncio bpo-31034: Reliable signal handler for test_asyncio

Jul 25, 2017

@brettcannon

Sorry about the title change noise: trying to figure out why this PR wasn't editable.

@Mariatta

@vstinner

why this PR wasn't editable

Did it do something wrong?

@brettcannon

@Haypo yep, we ran into a bug in GitHub's API that was automatically turning off the ability to edit PRs by project maintainers. New deployment of Bedevere works around the bug and I used this PR to test the fix. 😀

@vstinner

"New deployment of Bedevere works around the bug and I used this PR to test the fix. 😀"

Oh ok, no problem. It seems like at the end, it works, nice ;-)

@bedevere-bot

vstinner added a commit that referenced this pull request

Jul 26, 2017

@vstinner

Don't rely on the current SIGHUP signal handler, make sure that it's set to the "default" signal handler: SIG_DFL.

(cherry picked from commit 8300809)