bpo-31040: Add warning note about mimetypes.add_type ext argument format by OddBloke · Pull Request #2871 · python/cpython (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation8 Commits2 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
This addresses the documentation of the issue described in bpo-31040, but not the underlying issue.
Hello, and thanks for your contribution!
I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).
Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.
Thanks again to your contribution and we look forward to looking at it!
Add warning note about mimetypes.add_type ext argument format bpo-31040: Add warning note about mimetypes.add_type ext argument format
(I signed the CLA just before submitting this PR, so that should be cleared up fairly soon.)
| @@ -109,6 +109,11 @@ behavior of the module. |
|---|
| When *strict* is ``True`` (the default), the mapping will be added to the |
| official MIME types, otherwise to the non-standard ones. |
| .. note:: |
| The *ext* argument should start with a dot ("``.``") for the |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also explicitly tell it can be empty, see b.p.o.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.
Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
This PR is stale because it has been open for 30 days with no activity.
Closing as it's been almost three years since the requested change.
