bpo-45356: fix incorrect access of class property in pydoc and inspect by akulakov · Pull Request #29239 · python/cpython (original) (raw)

[guard against access of classproperties](/python/cpython/pull/29239/commits/7226d7df6e7a29d9ae5581a8bb41526f8ef444eb "guard against access of classproperties")

[7226d7d](/python/cpython/pull/29239/commits/7226d7df6e7a29d9ae5581a8bb41526f8ef444eb)

[fix help() and inspect.classify_class_attrs: prevent access of class …](/python/cpython/pull/29239/commits/4c78430990c06f3eb807fe6d243dcd9b09884faf "fix help() and inspect.classify_class_attrs: prevent access of class properties")

[4c78430](/python/cpython/pull/29239/commits/4c78430990c06f3eb807fe6d243dcd9b09884faf)

…properties

the-knights-who-say-ni added the CLA signed label

Oct 27, 2021

bedevere-bot added the awaiting review label

Oct 27, 2021

akulakov marked this pull request as draft

October 27, 2021 18:25

akulakov added 2 commits

October 27, 2021 15:44

[also look at MRO and expand test accordingly](/python/cpython/pull/29239/commits/d68d0a65939175d4bbeb6f4dd35aec3c32b0b3f7 "also look at MRO and expand test accordingly")

[d68d0a6](/python/cpython/pull/29239/commits/d68d0a65939175d4bbeb6f4dd35aec3c32b0b3f7)

[factor out _is_class_property](/python/cpython/pull/29239/commits/3cec62fd708347d5246df5991390475234845416 "factor out _is_class_property")

[3cec62f](/python/cpython/pull/29239/commits/3cec62fd708347d5246df5991390475234845416)

akulakov marked this pull request as ready for review

October 27, 2021 19:55

Copy link Copy Markdown

Contributor Author

akulakov commented

Oct 27, 2021

Ubuntu test failure seems unrelated (cache server 503 resp)

[add news entry](/python/cpython/pull/29239/commits/9c37c9c8edf03b52c71e6a886971ddd62e541b7d "add news entry")

[9c37c9c](/python/cpython/pull/29239/commits/9c37c9c8edf03b52c71e6a886971ddd62e541b7d)

rhettinger self-requested a review

November 19, 2021 08:12

MaxwellDupre approved these changes Apr 18, 2022

View reviewed changes

Copy link Copy Markdown

Contributor

@MaxwellDupre MaxwellDupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran 74 tests in 38.639s
OK (skipped=3)
Looks ok.

bedevere-bot added awaiting core review and removed awaiting review labels

Apr 18, 2022

randolf-scholz mannequin mentioned this pull request

May 6, 2022

Calling help executes @classmethod @property decorated methods#89519

Closed

ezio-melotti removed the CLA signed label

Jul 13, 2022

Copy link Copy Markdown

Contributor

nineteendo commented

Jun 18, 2024

Ehm, shouldn't this be closed now that classproperties no longer exist?

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})