bpo-30781: IDLE - Use ttk Notebook in ConfigDialog by terryjreedy · Pull Request #2938 · python/cpython (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation2 Commits6 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Add clear method for tests. Adjust tests to use global instance. Remove unneeded ConfigDialog method.
Wow! I didn't expect a notebook! It looks good.
The initial font on highlight_sample isn't right, but it's wrong on my master too, not just this branch.
Edit: highlight_sample broke when set_samples was removed from the command. Before the change, setting one of the font variables must have triggered the event. set_samples would have been called and thus change the font on highlight_sample, but now it's not being called at that time. I think set_samples needs to be called explicitly at the end of load_font_cfg.
When load font config is called, there tracers are not attached, which should mean that this docstring comment -- ' Setting font variables calls set_samples (thrice).' - should be wrong. Try adding back self.set_samples() at the bottom of the method. (I think it may have been there and I removed it when we put the set_samples() call into the tracers.
The tracers are attached when the load tests are run. Unless and until we change the timing, those tests should detach at the top and re-attach at the end.
terryjreedy added a commit to terryjreedy/cpython that referenced this pull request
The notebook looks a bit better. It will work better with separate page classes. Traversal of widgets by Tab works better. Switching tabs with keys becomes possible. The font sample box works better at large font sizes.
One of the two simulated click tests no longer works. This will be investigated while fixing a bug with the widget itself. (cherry picked from commit b331f80)
terryjreedy added a commit that referenced this pull request
The notebook looks a bit better. It will work better with separate page classes. Traversal of widgets by Tab works better. Switching tabs with keys becomes possible. The font sample box works better at large font sizes.
One of the two simulated click tests no longer works. This will be investigated while fixing a bug with the widget itself. (cherry picked from commit b331f80)