bpo-28533: Remove asyncore, asynchat, smtpd modules by vstinner · Pull Request #29521 · python/cpython (original) (raw)
Remove the asyncore and asynchat modules, deprecated in Python
3.6: use the asyncio module instead.
Remove the smtpd module, deprecated in Python 3.6: the aiosmtpd
module can be used instead, it is based on asyncio.
- Remove asyncore, asynchat and smtpd documentation
- Remove test_asyncore, test_asynchat and test_smtpd
- Rename Lib/asynchat.py to Lib/test/support/_asynchat.py
- Rename Lib/asyncore.py to Lib/test/support/_asyncore.py
- Rename Lib/smtpd.py to Lib/test/support/_smtpd.py
- Remove DeprecationWarning from private _asyncore, _asynchat and
_smtpd modules - _smtpd: remove deprecated properties
https://bugs.python.org/issue28533
Remove the asyncore and asynchat modules, deprecated in Python 3.6: use the asyncio module instead.
Remove the smtpd module, deprecated in Python 3.6: the aiosmtpd module can be used instead, it is based on asyncio.
- Remove asyncore, asynchat and smtpd documentation
- Remove test_asyncore, test_asynchat and test_smtpd
- Rename Lib/asynchat.py to Lib/test/support/_asynchat.py
- Rename Lib/asyncore.py to Lib/test/support/_asyncore.py
- Rename Lib/smtpd.py to Lib/test/support/_smtpd.py
- Remove DeprecationWarning from private _asyncore, _asynchat and _smtpd modules
- _smtpd: remove deprecated properties
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's time for these long-deprecated packages to leave.
🤖 New build scheduled with the buildbot fleet by @tiran for commit 1bf97aa 🤖
If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.
I looked at buildbot failures:
- AMD64 Windows10: unrelated, test_importlib failed. It looks like a Git clone issue. Not sure why it occurs on "PR" builds.
- AMD64 Arch Linux Asan PR: unrelated, https://bugs.python.org/issue45797
Merged. I prefer to merge such change early in the 3.11 devcycle, so we can revert it if it breaks too many projects.
Thanks for the reviews and approvals!
vstinner added a commit that referenced this pull request
remykarem pushed a commit to remykarem/cpython that referenced this pull request
Remove the asyncore and asynchat modules, deprecated in Python 3.6: use the asyncio module instead.
Remove the smtpd module, deprecated in Python 3.6: the aiosmtpd module can be used instead, it is based on asyncio.
- Remove asyncore, asynchat and smtpd documentation
- Remove test_asyncore, test_asynchat and test_smtpd
- Rename Lib/asynchat.py to Lib/test/support/_asynchat.py
- Rename Lib/asyncore.py to Lib/test/support/_asyncore.py
- Rename Lib/smtpd.py to Lib/test/support/_smtpd.py
- Remove DeprecationWarning from private _asyncore, _asynchat and _smtpd modules
- _smtpd: remove deprecated properties
