bpo-10202: Added resilience for broken or troublesome connections in ftplib (GH-30747) by MaxwellDupre · Pull Request #30747 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation5 Commits3 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

MaxwellDupre

Checks for EOF in storbinary and storlines and raises excpetion if not
completed successfully. Also, added SO_LINGER flag on socket shutdown.
Attempt is made to send outstanding data on shutdown in socket module,
for Linux only.

https://bugs.python.org/issue10202

@MaxwellDupre

Checks for EOF in storbinary and storlines and raises excpetion if not completed successfully. Also, added SO_LINGER flag on socket shutdown. Attempt is made to send outstanding data on shutdown in socket module, for Linux only.

@MaxwellDupre MaxwellDupre changed the titlebpo-10202: Added resilience for broken or troublesome connections in ftplib (GH-NNNN) bpo-10202: Added resilience for broken or troublesome connections in ftplib (GH-30747)

Jan 21, 2022

@MaxwellDupre

@MaxwellDupre

Hi, I have fixed the ftplib.rst spaces issue but dont know how to update the file in here. Done a git push origin but cant do a push upstream (error: 403).
Also for the other failures how do I get a command line (plus data) so that I can run locally?

@MaxwellDupre

Oh and how do I add a skip news label?

@AlexWaygood

Oh and how do I add a skip news label?

You can't 🙂 only core developers and triagers can, I'm afraid. I am a triager, but I'm afraid I think this probably warrants a news entry if it warrants a .. versionchanged section in the docs, so I'm not entirely sure the "skip-news" label is appropriate here.

You can add a news entry using https://blurb-it.herokuapp.com/

@MaxwellDupre

Ok, thanks for letting me know, I won’t worry about it anymore. But yes understand your comment I can add an entry in news. Thanks. On Sat, 22 Jan 2022 at 13:46, Alex Waygood ***@***.***> wrote: ...

@MaxwellDupre

@MaxwellDupre

Cant get changes back into this PR, so will create another PR.