bpo-31354: Fixing a bug related to LTO only build by octaviansoldea · Pull Request #3110 · python/cpython (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation4 Commits2 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Dear Reviewers,
Following several previous communications, this pull request enables compilation of cpython with lto only optimization. While configure’s flag --with-lto is to be used, a new make target has been added: make build_all_lto .
I am looking forward to receive feedback from you.
Best regards,
Octavian
https://bugs.python.org/issue31354
Hello, and thanks for your contribution!
I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).
Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.
Thanks again to your contribution and we look forward to looking at it!
There is an update I am working for adding lto only compilation option. Please let me add this modification before spending any additional time in reviewing the previous commit.
Enabling separate lto only compilation mode helps the trade-off capabilities between required compilation time and optimization results. Moreover, it enables studies of performance on different platforms.
Signed-off-by: Octavian Soldea octavian.soldea@intel.com
Enabling - lto only - optimization compilation mode bpo-31354: Fixing a bug related to LTO only build
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I would like to see a review by another core dev :-)
